[pve-devel] [PATCH manager 3/6] 5to6: fail if a corosync node has neither ring0 nor ring1 defined

Fabian Grünbichler f.gruenbichler at proxmox.com
Fri Jul 5 14:44:07 CEST 2019


Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---

Notes:
    this would need an update once we support the other rings/links as well, but
    since this is for pre/post upgrade checking IMHO this is fine..

 PVE/CLI/pve5to6.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
index 07d39c9f..ec98b81a 100644
--- a/PVE/CLI/pve5to6.pm
+++ b/PVE/CLI/pve5to6.pm
@@ -366,6 +366,8 @@ sub check_cluster_corosync {
 	    if !defined($entry->{name});
 	log_fail("$cs_node: no nodeid configured in corosync.conf.")
 	    if !defined($entry->{nodeid});
+	log_fail("$cs_node: neither ring0_addr nor ring1_addr defined in corosync.conf.")
+	    if !defined($entry->{ring0_addr}) && !defined($entry->{ring1_addr});
 
 	my $verify_ring_ip = sub {
 	    my $key = shift;
-- 
2.20.1





More information about the pve-devel mailing list