[pve-devel] applied: [PATCH manager 2/2] pve5to6: check ipv6/ipv4 settings in ceph.conf

[Thomas Lamprecht]

On 7/4/19 9:35 AM, Dominik Csapak wrote:
> having ipv6 enabled while not disabling ipv4 prevents
> nautilus osds to start if no ipv4 network is given (because they
> are trying to bind to both ip families and die if one of them
> is not found)
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/CLI/pve5to6.pm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
> index bb54c735..590a4776 100644
> --- a/PVE/CLI/pve5to6.pm
> +++ b/PVE/CLI/pve5to6.pm
> @@ -430,6 +430,17 @@ sub check_ceph {
>  	} else {
>  	    log_pass("Found mon_host entry.");
>  	}
> +
> +	if (my $ipv6 = ($global->{ms_bind_ipv6} // $global->{"ms bind ipv6"})) {
> +	    my $ipv4 = $global->{ms_bind_ipv4} // $global->{"ms bind ipv4"};
> +	    if ($ipv6 eq 'true' && (!defined($ipv4) || $ipv4 ne 'false')) {
> +		log_warn("ms_bind_ipv6 is enabled but ms_bind_ipv4 is not disabled.\n  Make sure to disable ms_bind_ipv4 for ipv6 only clusters, or add an ipv4 network to public/cluster network.");
> +	    } else {
> +		log_pass("ms_bind_ipv6 is enabled and ms_bind_ipv4 disabled");
> +	    }
> +	} else {
> +	    log_pass("ms_bind_ipv6 not enabled");
> +	}
>      } else {
>  	log_skip("no ceph config found");
>      }
> 

applied, with similar followup to also detect "ms-bind-ipv4" et al.