[pve-devel] [PATCH manager 1/2] pve5to6: check ceph config for mon_host line

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 4 10:46:31 CEST 2019


On 7/4/19 10:16 AM, Thomas Lamprecht wrote:
>> should always be defined, as neither cfs_read_file should return undef
>> itself, nor can the parser for ceph.conf.
> FYI: if the file does not exists you get undef...
> https://git.proxmox.com/?p=pve-cluster.git;a=blob;f=data/PVE/Cluster.pm;h=b53dcd726f9d42cd8e94c59fb584818e79c94ad7;hb=HEAD#l873
> also it does not harm, it's just a safe guard.
> 

I now get your point with "cfs_read_file should return undef" as it always
puts the file content, undef or not through the parser, so it's only the
parsers say if there can be an undef config at all, which in ceph case isn't,
I minded that in m followup.




More information about the pve-devel mailing list