[pve-devel] [PATCH v2 manager 1/2] fix #1451: allow some extra mount options for lxc

Oguz Bektas o.bektas at proxmox.com
Thu Jul 4 10:50:20 CEST 2019


this allows the following mount options for lxc container rootfs or
mountpoints:
* noatime
* nosuid
* noexec
* nodev

Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
---

v1-> v2:
* remove leftover code
* use gettext


 www/manager6/lxc/MPEdit.js | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
index c7c3870a..e33cf54d 100644
--- a/www/manager6/lxc/MPEdit.js
+++ b/www/manager6/lxc/MPEdit.js
@@ -29,6 +29,9 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
 
 	var confid = me.confid || "mp"+values.mpid;
 	values.file = me.down('field[name=file]').getValue();
+	if (values.mountoptions) {
+	    values.mountoptions = values.mountoptions.join(';');
+	}
 
 	if (me.unused) {
 	    confid = "mp"+values.mpid;
@@ -52,6 +55,9 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
 	var me = this;
 	var vm = this.getViewModel();
 	vm.set('mptype', mp.type);
+	if (mp.mountoptions) {
+	    mp.mountoptions = mp.mountoptions.split(';');
+	}
 	me.setValues(mp);
     },
 
@@ -275,6 +281,21 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
 	    allowBlank: true
 	},
 	{
+	    xtype: 'proxmoxKVComboBox',
+	    name: 'mountoptions',
+	    fieldLabel: gettext('Mount options'),
+	    deleteEmpty: false,
+	    comboItems: [
+		['noatime', 'noatime'],
+		['nodev', 'nodev'],
+		['noexec', 'noexec'],
+		['nosuid', 'nosuid']
+	    ],
+	    multiSelect: true,
+	    value: [],
+	    allowBlank: true
+	},
+	{
 	    xtype: 'proxmoxcheckbox',
 	    inputValue: '0', // reverses the logic
 	    name: 'replicate',
-- 
2.11.0





More information about the pve-devel mailing list