[pve-devel] [PATCH manager 1/4] 5to6: add check for configured Sheepdog storages

[Fabian Grünbichler]

On Wed, Jul 03, 2019 at 03:41:54PM +0200, Thomas Lamprecht wrote:
> On 7/3/19 3:28 PM, Fabian Grünbichler wrote:
> > Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> > ---
> > this is mainly relevant for stable-5, since master already drops them from the storage.cfg
> > 
> >  PVE/CLI/pve5to6.pm | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
> > index c167ebca..e9373288 100644
> > --- a/PVE/CLI/pve5to6.pm
> > +++ b/PVE/CLI/pve5to6.pm
> > @@ -234,7 +234,9 @@ sub check_storage_health {
> >      foreach my $storeid (keys %$info) {
> >  	my $d = $info->{$storeid};
> >  	if ($d->{enabled}) {
> > -	    if ($d->{active}) {
> > +	    if ($d->{type} eq 'sheepdog') {
> > +		log_fail("storage '$storeid' of type 'sheepdog' is enabled - Sheepdog is no longer supported in PVE 6.x!")
> 
> it was not really supported with 5 either, so:
> 
> "- experimental sheepdog support dropped in PVE 6"?

also okay for me :)

> > +	    } elsif ($d->{active}) {
> >  		log_pass("storage '$storeid' enabled and active.");
> >  	    } else {
> >  		log_warn("storage '$storeid' enabled but not active!");
> > 
> 
>