[pve-devel] [PATCH common 1/5] Export getaddrinfo helpers

[Fabian Grünbichler]

On Mon, Jul 01, 2019 at 10:49:20AM +0200, Stefan Reiter wrote:
> Needed for corosync related firewall updates.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  src/PVE/Tools.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index 4dd073f..77af21c 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -47,6 +47,8 @@ safe_print
>  trim
>  extract_param
>  file_copy
> +unpack_sockaddr_in46
> +getaddrinfo_all

IMHO this have too few users (2/3 currently) to warrant being exported.
most other stuff in this list is used well into the double-digits all
over our code base ;)

if you send a v2 of this series, I'd just drop this and adjust the rest
to use PVE::Tools::foo()

>  O_PATH
>  O_TMPFILE
>  );
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel