[pve-devel] [PATCH manager] Add context menu to global search entries

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jan 28 13:37:21 CET 2019


On 1/28/19 11:19 AM, Christian Ebner wrote:
> This add a context menu to the entries of the global search field instead of
> showing the browsers default one.
> This allows to search and easily manage nodes, VMs and CTs similar to the
> behaviour in the resource tree.

Look OK in general, but I observe a bit odd behavior here.
If I open the context menu and move my mouse pointer to a button in it the
global search gets hidden. Could happen if I clicked on the wrong element,
or just test around to see what's in the context menus.

IMO, it could be a better UX if the search box stays open as long nothing is
selected, did not looked to see how easy that'd be, though.

> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
>  www/manager6/form/GlobalSearchField.js | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/www/manager6/form/GlobalSearchField.js b/www/manager6/form/GlobalSearchField.js
> index cac33f78..2cf2d126 100644
> --- a/www/manager6/form/GlobalSearchField.js
> +++ b/www/manager6/form/GlobalSearchField.js
> @@ -61,6 +61,7 @@ Ext.define('PVE.form.GlobalSearchField', {
>  		var me = this;
>  		me.textfield.selectAndHide(record.id);
>  	    },
> +	    itemcontextmenu: PVE.Utils.createCmdMenu,
>  	    /* because of lint */
>  	    focusleave: {
>  		fn: 'hideMe'
> 





More information about the pve-devel mailing list