[pve-devel] [PATCH qemu-server v2 0/3] Fix #2041 and #413

[Dominik Csapak]

hi,

thanks for the patches,
generally look ok, but a few high level things:

it would be nicer to not introduce breaking changes which gets fixed
with the next patch, better would be:

1/3 add option
2/3 add x when option is set
3/3 add y when option is set

this way, there is no breaking change introduced

also i am not sure if we want to link the audio device so closely with
spice? @all is there a good use case for having and audio devices
without spice? (vnc has no audio, rdp does not need a device, with
gpu passthrough you most likely have an hdmi audio or usb audio device,
so that only leaves spice?)

then as alexandre mentioned, this is only necessary with non q35
machines, as we have there an intel-hda audio device anyway
(we could do this as a follow up though)

also i think the logic for the winversion is in reverse,
as i think linux has support for intel hda?

so we probably want:  winver < 6 -> AC97 else intel hda ?
or is there any special reason why non windows machines get ac97?


On 1/8/19 11:57 PM, Andreas Steinel wrote:
> Add a new option 'spicedesktop' to enable audio and folder sharing.
> 
> More precisely, add another serial port in order to get the service
> spice-webdavd on Linux and Windows working. Afterwards you can use
> remote-viewer and enable folder sharing therein to get a new virtual
> inside of your guest for sharing files.
> 
> Based on the Windows version, there are two possible sound implementations
> used like it is described on the SPICE page on the wiki.
> 
> Signed-off-by: Andreas Steinel <A.Steinel at gmail.com>
> 
> Andreas Steinel (3):
>    Fix #2041: add spice webdav / folder sharing
>    fix #413: add SPICE audio device
>    Adding new config option 'spicedesktop'
> 
>   PVE/QemuServer.pm     | 22 ++++++++++++++++++++++
>   PVE/QemuServer/PCI.pm |  2 ++
>   2 files changed, 24 insertions(+)
>