[pve-devel] [PATCH container 1/1] Fix #2041: add spice webdav / folder sharing

[Andreas Steinel]

Hi Dominik,

On Wed, Jan 2, 2019 at 2:54 PM Dominik Csapak <d.csapak at proxmox.com> wrote:

> On 12/28/18 6:59 PM, Andreas Steinel wrote:
> > Adding the device and serial port for the service spice-webdavd on Linux
> and
> > Windows.
> >
>
> hi, thanks for the patch, a few points though
>
> only minor, but you have 'container' instead of 'qemu-server' in the
> subject prefix
>

Yeah, this was the first time I used git-email, normally I just commit. I
also added the patches to the bugreports.

> index 1ccdccf..225f0c0 100644
> > --- a/PVE/QemuServer.pm
> > +++ b/PVE/QemuServer.pm
> > @@ -3767,6 +3767,11 @@ sub config_to_command {
> >       push @$devices, '-device', "virtio-serial,id=spice$pciaddr";
> >       push @$devices, '-chardev', "spicevmc,id=vdagent,name=vdagent";
> >       push @$devices, '-device',
> "virtserialport,chardev=vdagent,name=com.redhat.spice.0";
> > +
> > +     $pciaddr = print_pci_addr("spicewebdav", $bridges, $arch,
> $machine_type);
> > +     push @$devices, '-device', "virtio-serial,id=webdav$pciaddr";
> > +     push @$devices, '-chardev',
> "spiceport,id=webdav,name=org.spice-space.webdav.0";
> > +     push @$devices, '-device',
> "virtserialport,chardev=webdav,name=org.spice-space.webdav.0";
>
> without testing, this for sure breaks live migration (since there is now
> new hardware)
>

Yeah, that should not happen.


> mainly there are 3 possibilities to include this by default with working
> live migration:
>
> [...]
> 2. add a new config option/property somewhere and add it by default in
> the wizard in the gui, this makes it only the default by vms created there

[...]


I think I'd want to have this, but I do not have any experience with
programming in JS or extjs.
I'm happy that I could integrate it into the perl code.

I also created the audio patch so that it'll work with spice audio. I'd
really want to have a new option
like "Desktop integration", because this is only needed if you want a "near
desktop experience" and
not always, like it is now.

I can try to rewrite my patch to do that. I'll have a look later this week.

-- 
With kind regards / Mit freundlichen Grüßen

Andreas Steinel
M.Sc. Visual Computing
M.Sc. Informatik