[pve-devel] [PATCH 0/8] move ssl-defaults and proxy-configuration from pve-manager to pve-http-server

Stoiko Ivanov s.ivanov at proxmox.com
Fri Feb 22 19:51:57 CET 2019


Moving the parsing of '/etc/default/pveproxy' from PVE::API2Tools (in pve-manager)
to PVE::APIServer::Utils (pve-http-server) (and making the configfile variable)
enables us to use the same logic in pmgproxy.

Additionally the default-values for SSL-related settings are put into
PVE::APIServer::Anyevent (like the other default-settings for our APIServers,
which reduces code-duplication between pveproxy and pmgproxy.

Initially I additionally tried to factor out the complete proxy-initialization,
but wasn't too happy with the result (quite a mixup of what happens where, for
dropping ~10 common code-lines).

The first patch for pve-manager (versioned dependency on pve-http-server) was
mostly a reminder for myself that we need to add it before releasing - feel
free to drop/replace it

pve-manager:
Stoiko Ivanov (4):
  add dependency on pve-http-server (>= 2.0.12)
  remove default values from pveproxy ssl config
  pveproxy, spiceproxy: new read_proxy_conf location
  remove read_proxy_conf from PVE::API2Tools

 PVE/API2Tools.pm          | 46 ----------------------------------------------
 PVE/Service/pveproxy.pm   | 18 +++++-------------
 PVE/Service/spiceproxy.pm |  4 ++--
 debian/control            |  4 ++--
 4 files changed, 9 insertions(+), 63 deletions(-)

pve-http-server:
Stoiko Ivanov (4):
  add ssl fallback values to AnyEvent->new
  Move read_proxy_conf from PVE::API2Tools
  Add short comment about users of read_proxy_config
  bsys: add Utils.pm to install target

 Makefile                  |  1 +
 PVE/APIServer/AnyEvent.pm | 18 +++++++++++++++
 PVE/APIServer/Utils.pm    | 57 +++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 76 insertions(+)
 mode change 100755 => 100644 PVE/APIServer/AnyEvent.pm
 create mode 100644 PVE/APIServer/Utils.pm

-- 
2.11.0




More information about the pve-devel mailing list