[pve-devel] [PATCH pve-firewall] service : cleanup + character at begin of line

Alexandre DERUMIER aderumier at odiso.com
Wed Feb 20 09:03:37 CET 2019


>>applied, thanks! one has to love perl syntax possibilities ;) 

yes ;)


>>one another note, could you please try to add your signed-off to your patches? 
>>While earlier it wasn't really a hard requirement, we now request it in the developer 
>>documentation[0]. Adding a simple '-s' switch on commit, format-patch, or send-email 
>>is enough as you have already configured git name and email. 
>>That'd be great, other (new) contributors see that it's really used and required then, 
>>and it makes things in the git log a bit more uniform, thanks! 
>>
>>[0]: https://pve.proxmox.com/wiki/Developer_Documentation#Using_git 

Sure no problem !



----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Mercredi 20 Février 2019 07:31:27
Objet: Re: [pve-devel] [PATCH pve-firewall] service : cleanup + character at begin of line

On 2/20/19 1:16 AM, Alexandre Derumier wrote: 
> --- 
> src/PVE/Service/pve_firewall.pm | 2 +- 
> 1 file changed, 1 insertion(+), 1 deletion(-) 
> 
> diff --git a/src/PVE/Service/pve_firewall.pm b/src/PVE/Service/pve_firewall.pm 
> index 5a0dd04..e70f6e5 100755 
> --- a/src/PVE/Service/pve_firewall.pm 
> +++ b/src/PVE/Service/pve_firewall.pm 
> @@ -170,7 +170,7 @@ __PACKAGE__->register_method ({ 
> my (undef, undef, $ipset_changes) = PVE::Firewall::get_ipset_cmdlist($ipset_ruleset, $verbose); 
> my ($test, $ruleset_changes) = PVE::Firewall::get_ruleset_cmdlist($ruleset, $verbose); 
> my (undef, $ruleset_changesv6) = PVE::Firewall::get_ruleset_cmdlist($rulesetv6, $verbose, "ip6tables"); 
> -+ my (undef, $ebtables_changes) = PVE::Firewall::get_ebtables_cmdlist($ebtables_ruleset, $verbose); 
> + my (undef, $ebtables_changes) = PVE::Firewall::get_ebtables_cmdlist($ebtables_ruleset, $verbose); 
> 
> $res->{changes} = ($ipset_changes || $ruleset_changes || $ruleset_changesv6 || $ebtables_changes) ? 1 : 0; 
> } 
> 

applied, thanks! one has to love perl syntax possibilities ;) 

one another note, could you please try to add your signed-off to your patches? 
While earlier it wasn't really a hard requirement, we now request it in the developer 
documentation[0]. Adding a simple '-s' switch on commit, format-patch, or send-email 
is enough as you have already configured git name and email. 
That'd be great, other (new) contributors see that it's really used and required then, 
and it makes things in the git log a bit more uniform, thanks! 

[0]: https://pve.proxmox.com/wiki/Developer_Documentation#Using_git 



More information about the pve-devel mailing list