[pve-devel] applied: [PATCH container v4 1/1] add hookscript to containers

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Feb 1 13:28:35 CET 2019


On 1/31/19 2:33 PM, Dominik Csapak wrote:> this adds the config (hookscript) and executes it
> on four points in time for the container
> 
> the same notes as with vms are in place regarding
> when the script is called

why not just copy over the text from the qemu-server commit message?
Else I need to search, maybe I'm not even sure which repository as VM
stuff could be guest-common or too, needlessly around if I want such an
info. This is near zero time for you and can save all others looking at
this, link references are OK but not vague text references. I copied
over the missing parts. Also, please try to use a common used text
character limit like 69 for commit messages, long lines are bad but so
are very short ones, the following line in my .vimrc helps me to do that
automatically:
au FileType gitcommit setlocal tw=69

> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v3:
> * more concise check
>  src/PVE/LXC.pm            |  9 +++++++++
>  src/PVE/LXC/Config.pm     | 12 +++++++++++-
>  src/lxc-pve-poststop-hook |  3 +++
>  3 files changed, 23 insertions(+), 1 deletion(-)

applied, thanks



More information about the pve-devel mailing list