[pve-devel] applied: [PATCH v2 manager] API: OSD: Fix #2496 Check OSD Network

[Thomas Lamprecht]

On 12/16/19 12:04 PM, Aaron Lauterer wrote:
> It's possible to have a situation where the cluster network (used for
> inter-OSD traffic) is not configured on a node. The OSD can still be
> created but can't communicate.
> 
> This check will abort the creation if there is no IP within the subnet
> of the cluster network present on the node. If there is no dedicated
> cluster network the public network is used as a failsafe even though
> this situation should not occur.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> 
> changes in v2:
> 
> * changed long if condition to the proposed solution by Thomas
> * to avoid confusion the subnets base address is shown in the error msg
>   instead of the address present in the ceph config, which is the
>   address of the first node the config was initially created on

yeah good idea! I'm actually on a changeset to allow select "masked" CIDR
nets for networks selectors like the ceph or migration-network ones, as
it's always a bit ugly if the node specific unmasked one is used,
especially if one edits it on another node then.

applied, with a slight followup for the error message, thanks!