[pve-devel] applied: [PATCH manager] ui: vm/HDEdit: fix backup checkbox default

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Dec 9 15:45:55 CET 2019


The recent change transformed this checkbox from a negative "No
Backup" to a positive "Backup" did not accounted for changing the
default fallback for the parseBoolean call.

As this would had suggested that disk are backed-up which aren't
backup, it could lead to pretty devastating results...

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 www/manager6/qemu/HDEdit.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index 8d469f6f..40055442 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -130,7 +130,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	}
 
 	values.hdimage = drive.file;
-	values.backup = PVE.Parser.parseBoolean(drive.backup, 1);
+	values.backup = PVE.Parser.parseBoolean(drive.backup, 0);
 	values.noreplicate = !PVE.Parser.parseBoolean(drive.replicate, 1);
 	values.diskformat = drive.format || 'raw';
 	values.cache = drive.cache || '__default__';
@@ -296,7 +296,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		    tag: 'div',
 		    'data-qtip': gettext('Include volume in backup job'),
 		},
-		uncheckedValue: 'no',
 		labelWidth: labelWidth,
 		name: 'backup',
 		bind: {
-- 
2.20.1




More information about the pve-devel mailing list