[pve-devel] applied: [PATCH qemu-server] close #2263: die on live migration with local cloudinit disk

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Aug 26 12:14:03 CEST 2019


On 12.07.19 14:23, Mira Limbeck wrote:
> Live migration with a local cloudinit disk was never intended to work. It did
> however work to an extent that the migration completed but the disk on the
> source node could not be deleted. Now die if a live migration is started with
> a local cloudinit disk.
> 
> With the GUI changes live migration is already disabled as it recognizes the
> cloudinit disk as a local resource.
> 
> Signed-off-by: Mira Limbeck <m.limbeck at proxmox.com>
> ---
>  PVE/QemuMigrate.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index bc83816..661c96d 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.pm
> @@ -458,6 +458,7 @@ sub sync_disks {
>  	    if ($self->{running} && $ref eq 'config') {
>  		push @{$self->{online_local_volumes}}, $volid;
>  	    } elsif ($ref eq 'generated') {
> +		die "can't live migrate VM with local cloudinit disk. use a shared storage instead\n" if $self->{running};
>  		# skip all generated volumes but queue them for deletion in phase3_cleanup
>  		push @{$self->{volumes}}, $volid;
>  		next;
> 

applied, thanks!



More information about the pve-devel mailing list