[pve-devel] applied: [PATCH manager 1/2] fix #2340: gui: ceph: handle 'null' versions for hosts

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Aug 22 14:10:26 CEST 2019


On 8/22/19 12:26 PM, Dominik Csapak wrote:
> the api returns 'null' for a host that is in the crushmap, but
> without actual version information, so just check for falsyness instead
> of 'undefined', else we run later into javascript exceptions and no
> content on the osd page
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> i am not so sure if the api return 'null' is a bug too, but this change
> here is easy and does the right thing also
> 
> we can also change the 'compare_ceph_version' method so that it
> can properly handle undefined and null values, if wanted
> 

could be an good idea anyway, but for now: applied, thanks!



More information about the pve-devel mailing list