[pve-devel] [PATCH manager] Delete "exclude" when switching a backup job to pool

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Aug 14 15:32:37 CEST 2019

Am 8/14/19 um 3:23 PM schrieb Stefan Reiter:
>> But then the WebGUI would need to be adapted to cope with such a case,
>> as currently adding excludes to a pool based backup job results in a
>> rather strange and wrong visualization, e.g., "All except 1074" here,
>> but all is not selected and editing the job shows an inconsistent wrong
>> state too.
> That's why I made the patch to the UI, since it is the component that breaks. If the user knows what they are doing, they can still do so. I see your point though.

But there can be multiple admins, or some time between the manual change,
if then someone tries to edit this over GUI it could be really confusing
why the state is as it is, so the backend is the correct way.
Possible backend states settable through API should not break GUI
(if they're just not exposed in GUI, OK, that's something else) and
here most of the time the two options are:
* adapt GUI to allow coping with all of the possible backend states
* adapt backend to avoid/forbid those states which are not wanted

>> "Pool Based" backup jobs should stay simple, and as it does not really
>> works in all cases I'd rather prevent exclusions with that mode.
>> People needing to exclude some VMs can just use other modes..
> In that case I'd say we go for Tims backend version. I'll send the change as a v2 to make it better to apply.


More information about the pve-devel mailing list