[pve-devel] applied-series: [PATCH widget-toolkit/manager] add clear trigger to combogrid

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Aug 13 16:08:05 CEST 2019


Am 7/24/19 um 9:21 AM schrieb Dominik Csapak:
> this series adds a clear trigger for the combogrid where allowblank
> is set to true
> 
> i am not sure about the dependencies, but the second patch from
> widget-toolkit 'needs' the pve-manager changes already, so maybe
> a versioned 'breaks' is in order?
> 
> also we could do the same for pmg-api/gui but we do not
> use any combogrid with allowblank there so it would be a change
> for no gain (atm)
> 

applied series, thanks!

Something small I noticed, if you try to add a new storage in "PVE: DC
-> Storages" the trigger shows already in the "Nodes" field initially,
clicking it does nothing (the field is already empty, so expected) but
hides the trigger - you may want to take a look at this, but it's a
small glitch so no stress :)

> proxmox-widget-toolkit:
> 
> Dominik Csapak (2):
>   add css and image directory to packaging
>   ComboGrid: add trigger to delete from ComboGrid
> 
>  Makefile                     |  18 +++++-------------
>  css/Makefile                 |  13 +++++++++++++
>  css/ext6-pmx.css             |   3 +++
>  defines.mk                   |  15 +++++++++++++++
>  form/ComboGrid.js            |  18 ++++++++++++++++++
>  images/Makefile              |  13 +++++++++++++
>  images/pmx-clear-trigger.png | Bin 0 -> 11118 bytes
>  7 files changed, 67 insertions(+), 13 deletions(-)
>  create mode 100644 css/Makefile
>  create mode 100644 css/ext6-pmx.css
>  create mode 100644 defines.mk
>  create mode 100644 images/Makefile
>  create mode 100644 images/pmx-clear-trigger.png
> 
> pve-manager:
> 
> Dominik Csapak (1):
>   add the css/images from proxmox widget toolkit
> 
>  PVE/Service/pveproxy.pm | 2 ++
>  www/index.html.tpl      | 1 +
>  2 files changed, 3 insertions(+)
> 




More information about the pve-devel mailing list