[pve-devel] [PATCH qemu-server] api resume: drop nocheck parameter

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Aug 12 12:06:28 CEST 2019


Am 8/7/19 um 1:57 PM schrieb Fabian Grünbichler:
> On May 25, 2019 5:09 pm, Thomas Lamprecht wrote:
>> Once, this was used when transferring the VM state finsihed on a
>> migration to another node to resume the VM there again, it was called
>> through SSH using the 'qm resume' command, which bases on this API
>> call.
>>
>> As we switched over to a mechanism re-using our "migration tunnel",
>> which stays open during the whole connection, as command tunnel we
>> resumed the VM directly from there, omitting an extra SSH connection.
>>
>> As we _require_ people to upgrade to latest 5.4 before upgrading to
>> 6.0 we can safely drop this now.
> while going through my pve-devel backlog, I noticed that we didn't 
> actually apply this in time for 6.x - do we still want to drop this 
> (since it was basically added for one internal use case) or just mark it 
> for removal in PVE 7.x (it is part of the public API :-/)
> 

Hmm, yeah forgot it then too, just should had applied it straight then :D

I'd really like to just drop it now, it's quite internal and, while
public, the use of it should not be necessary by any API user, IMO.

But, this depends on how strict we see the API interface stability,
I think that sometimes, case-by-case controlled, it could be ignored
(with a mentioning in the changelog, naturally), as keeping this
parameter does not really hurts us, it probably isn't such a case, though.



More information about the pve-devel mailing list