[pve-devel] [PATCH qemu] add pve-api-updates trigger

Dominik Csapak d.csapak at proxmox.com
Mon Aug 12 10:37:28 CEST 2019


we want to notify the api that there is a new qemu-binary, since
the version will be cached in qemu-server and instead of
checking the version every time, just restart pveproxy/pvedaemon
whenever there is a qemu update

this fixes a rare theoretical issue when only updating qemu, that
the pvedaemon starts a vm with a new version but with the
defaults of an old version because of the version cache,
breaking live migration

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
i do not know if that issue was ever triggered, but it seems
very unlikely, so this is just to be safe

the other alternative, either dont cache the version, or caching
and checking the file timestamp would also work, but this is the 'cheaper'
solution overall, since we do not update pve-qemu-kvm that often

 debian/triggers | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 debian/triggers

diff --git a/debian/triggers b/debian/triggers
new file mode 100644
index 0000000..59dd688
--- /dev/null
+++ b/debian/triggers
@@ -0,0 +1 @@
+activate-noawait pve-api-updates
-- 
2.20.1





More information about the pve-devel mailing list