[pve-devel] [PATCH v2 manager 1/3] fix #1594: add "Run now" button to cluster backup page

Dominik Csapak d.csapak at proxmox.com
Wed Aug 7 11:40:44 CEST 2019


>> at this point, the user may have switched the panel already and it 
>> might seem weird to get an error 'out of nowhere'...
>>
>> you could check 'me.destroyed' (see extjs docs) if the current panel 
>> still is valid and only show the errors if it is.
>> also, if it is not, the 'unmask' in run_now_finished
>> will probably fail anyway, so in that case the error will not get 
>> shown...
>>
> 
> In my testing, the call always returned fast, as long as nothing went 
> bad with the connection, so the time span in which the user can click 
> away is minimal to begin with.

that is true only with a fast connection to the cluster, as soon as you 
have higher latency this will bite the users..

also one problem is if a node gets offline while clicking, then this
blocks you a few seconds for sure...

> 
> Adding a check for 'me.destroyed' is a good idea, but the issue remains 
> that the user will not be informed of any errors that might have occured 
> if they click away.

yes, this is a problem that remains, but is there not a task log entry 
for backups?

> 
> Any other suggestions? Mask the entire window?
> 
could work yes, or a model window that gets completely masked instead of 
the grid..



More information about the pve-devel mailing list