[pve-devel] [PATCH manager] Delete "exclude" when switching a backup job to pool

Stefan Reiter s.reiter at proxmox.com
Tue Aug 6 11:17:53 CEST 2019

Previously, if you selected a job in "exclude" mode (in DC GUI) with some VMIDs
selected and then switched that backup job to "pool", the backup job would
retain the "exclude" section and thus not back up all VMs.

The backend technically supports this, but the GUI would then misrepresent this,
showing that all VMs will be backed up (when in reality some will be excluded)
or straight up break and show "exclude" mode again, with the backend still being
on "pool".

Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
 www/manager6/dc/Backup.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 6810d92f..79e9cace 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -251,6 +251,8 @@ Ext.define('PVE.dc.BackupEdit', {
 		    values.exclude = values.vmid;
 		    delete values.vmid;
 		} else if (selMode === 'pool') {
+		    delete values.exclude;
+		    Proxmox.Utils.assemble_field_data(values, { 'delete': 'exclude' });
 		    delete values.vmid;

More information about the pve-devel mailing list