[pve-devel] [PATCH v2 0/3] fix #1594 and clean up backup

Stefan Reiter s.reiter at proxmox.com
Mon Aug 5 16:58:04 CEST 2019

Thanks for the reviews on v1! I decided to do away with the new API path
entirely as Fabian suggested.

v1 -> v2:
* Remove API path, call /vzdump on all nodes from client directly
* Remove check for Sys.Modify permission (only regular VZDump backup perms are
  needed now)
* Only contact online nodes
* Fix masking
* Fix pve-cluster-backup data model
* Split cleanup into seperate commit and include new variable for job_id format

manager: Stefan Reiter (3):
  fix #1594: add "Run now" button to cluster backup page
  fix #1594: allow skipping VMIDs on other nodes from API
  Code cleanup in Backup

 PVE/API2/Backup.pm        |  25 ++++------
 PVE/API2/VZDump.pm        |   2 +-
 www/manager6/dc/Backup.js | 102 +++++++++++++++++++++++++++++++++-----
 3 files changed, 100 insertions(+), 29 deletions(-)


More information about the pve-devel mailing list