[pve-devel] [PATCH manager] Old doc dependency

Mon Apr 15 18:03:28 CEST 2019

i see now. missed that in the make output. thanks fabian!

On Mon, Apr 15, 2019 at 05:31:39PM +0200, Fabian Grünbichler wrote:
> On Mon, Apr 15, 2019 at 04:36:27PM +0200, Oguz Bektas wrote:
> > hi,
> > why is this necessary exactly? on my setup it compiled properly without
> > the new pve-doc-generator version. we usually don't bump the
> > build-dependencies unless it's needed for some reason. there are many
> > other packages in the build-deps that are also outdated versions, but it
> > works normally.
> > what is the justification for this bump?
> 
> the referenced 'pveum_tfa_auth' and 'qm_system_settings' blocks are only
> available in pve-doc-generator >= 5.4-2, leading to:
> 
> make[4]: Entering directory '/home/builder/source/dest/www/manager6'
> /usr/bin/asciidoc-pve scan-extjs Utils.js Toolkit.js Parser.js StateProvider.js menu/MenuItem.js menu/TemplateMenu.js button/ConsoleButton.js button/Split.js controller/StorageEdit.js qemu/CmdMenu.js lxc/CmdMenu.js node/CmdMenu.js VNCConsole.js data/PermPathStore.js data/ResourceStore.js data/model/Realm.js data/model/RRDModels.js form/VLanField.js form/Boolean.js form/CompressionSelector.js form/PoolSelector.js form/PrivilegesSelector.js form/GroupSelector.js form/UserSelector.js form/RoleSelector.js form/GuestIDSelector.js form/MemoryField.js form/NetworkCardSelector.js form/DiskFormatSelector.js form/DiskSelector.js form/BusTypeSelector.js form/ControllerSelector.js form/EmailNotificationSelector.js form/RealmComboBox.js form/ViewSelector.js form/NodeSelector.js form/FileSelector.js form/StorageSelector.js form/DiskStorageSelector.js form/BridgeSelector.js form/PCISelector.js form/MDevSelector.js form/SecurityGroupSelector.js form/IPRefSelector.js form/IPProtocolSelector.js form/CPUModelSelector.js form/VNCKeyboardSelector.js form/CacheTypeSelector.js form/SnapshotSelector.js form/ContentTypeSelector.js form/HotplugFeatureSelector.js form/AgentFeatureSelector.js form/iScsiProviderSelector.js form/DayOfWeekSelector.js form/BackupModeSelector.js form/ScsiHwSelector.js form/FirewallPolicySelector.js form/GlobalSearchField.js form/QemuBiosSelector.js form/VMSelector.js form/USBSelector.js form/CalendarEvent.js form/CephPoolSelector.js form/PermPathSelector.js dc/Tasks.js dc/Log.js panel/StatusPanel.js panel/StatusView.js panel/GuestStatusView.js panel/RunningChart.js panel/InfoWidget.js panel/TemplateStatusView.js panel/HealthWidget.js window/LoginWindow.js window/Wizard.js window/NotesEdit.js window/Backup.js window/Restore.js window/SafeDestroy.js window/BackupConfig.js window/Settings.js window/StartupEdit.js window/CephInstall.js window/FirewallEnableEdit.js window/FirewallLograteEdit.js panel/NotesView.js grid/ResourceGrid.js grid/PoolMembers.js grid/FirewallRules.js grid/FirewallAliases.js grid/FirewallOptions.js tree/ResourceTree.js panel/IPSet.js panel/ConfigPanel.js grid/BackupView.js ceph/FS.js ceph/Pool.js ceph/OSD.js ceph/Monitor.js ceph/Crush.js ceph/Status.js ceph/StatusDetail.js ceph/Config.js ceph/Log.js ceph/CephInstallWizard.js node/Disks.js node/LVM.js node/LVMThin.js node/Directory.js node/ZFS.js node/StatusView.js node/Summary.js node/Subscription.js node/Certificates.js node/ACME.js node/Config.js window/Migrate.js window/BulkAction.js window/Clone.js qemu/Monitor.js qemu/Summary.js qemu/OSTypeEdit.js qemu/OSDefaults.js qemu/ProcessorEdit.js qemu/BootOrderEdit.js qemu/MemoryEdit.js qemu/NetworkEdit.js qemu/Smbios1Edit.js qemu/CDEdit.js qemu/HDEdit.js qemu/HDResize.js qemu/HDMove.js qemu/HDEfi.js qemu/DisplayEdit.js qemu/KeyboardEdit.js qemu/HardwareView.js qemu/ScsiHwEdit.js qemu/QemuBiosEdit.js qemu/Options.js qemu/Snapshot.js qemu/SnapshotTree.js qemu/Config.js qemu/CreateWizard.js qemu/USBEdit.js qemu/PCIEdit.js qemu/SerialEdit.js qemu/AgentIPView.js qemu/CloudInit.js qemu/CIDriveEdit.js qemu/SSHKey.js qemu/IPConfigEdit.js qemu/SystemEdit.js lxc/Summary.js lxc/Network.js lxc/Resources.js lxc/FeaturesEdit.js lxc/Options.js lxc/DNS.js lxc/Config.js lxc/CreateWizard.js lxc/SnapshotTree.js lxc/Snapshot.js lxc/ResourceEdit.js lxc/MPResize.js lxc/MPEdit.js pool/StatusView.js pool/Summary.js pool/Config.js storage/Base.js storage/ContentView.js storage/StatusView.js storage/Summary.js storage/Browser.js storage/DirEdit.js storage/NFSEdit.js storage/CIFSEdit.js storage/GlusterFsEdit.js storage/IScsiEdit.js storage/LVMEdit.js storage/LvmThinEdit.js storage/CephFSEdit.js storage/RBDEdit.js storage/SheepdogEdit.js storage/ZFSEdit.js storage/ZFSPoolEdit.js ha/StatusView.js ha/Status.js ha/GroupSelector.js ha/ResourceEdit.js ha/Resources.js ha/GroupEdit.js ha/Groups.js ha/Fencing.js dc/Summary.js grid/Replication.js dc/Health.js dc/Guests.js dc/OptionView.js dc/StorageView.js dc/TFAEdit.js dc/UserEdit.js dc/UserView.js dc/PoolView.js dc/PoolEdit.js dc/GroupView.js dc/GroupEdit.js dc/RoleView.js dc/RoleEdit.js dc/ACLView.js dc/AuthView.js dc/AuthEdit.js dc/Backup.js dc/Support.js dc/SecurityGroups.js dc/Config.js dc/NodeView.js dc/Cluster.js dc/ClusterEdit.js Workspace.js >OnlineHelpInfo.js.tmp
> undefined blockid 'qm_system_settings' (qemu/SystemEdit.js, line 6)
> Makefile:232: recipe for target 'OnlineHelpInfo.js' failed
> make[4]: *** [OnlineHelpInfo.js] Error 25
> make[4]: Leaving directory '/home/builder/source/dest/www/manager6'
> Makefile:5: recipe for target 'all' failed
> 
> when building with an older version (5.3-3 in this case).
> 
> > 
> > On Mon, Apr 15, 2019 at 12:17:43PM +0200, Dominic Jäger wrote:
> > > When building a current version of pve-manager a dependency to the
> > > documentation is missing.
> > > 
> > > Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
> > > ---
> > >  debian/control | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/debian/control b/debian/control
> > > index 038f776d..cdf55397 100644
> > > --- a/debian/control
> > > +++ b/debian/control
> > > @@ -16,7 +16,7 @@ Build-Depends: debhelper (>= 9~),
> > >                 lintian,
> > >                 pve-cluster,
> > >                 pve-container,
> > > -               pve-doc-generator (>= 5.3-3),
> > > +               pve-doc-generator (>= 5.4-2),
> > >                 qemu-server,
> > >                 unzip,
> > >  Maintainer: Proxmox Support Team <support at proxmox.com>
> > > -- 
> > > 2.11.0
> > > 
> > > _______________________________________________
> > > pve-devel mailing list
> > > pve-devel at pve.proxmox.com
> > > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> > 
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel at pve.proxmox.com
> > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel