[pve-devel] [PATCH v6 qemu-server 2/3] add QemuMigrateExternal.pm

[Alexandre DERUMIER]

>>The VM created in the 'prepare' sub never gets deleted if it fails there 
>>already. Cleanup only happens for phases 1, 2 and 3.

Thanks. I'll fix that.

----- Mail original -----
De: "Mira Limbeck" <m.limbeck at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 1 Avril 2019 10:12:02
Objet: Re: [pve-devel] [PATCH v6 qemu-server 2/3] add QemuMigrateExternal.pm

The VM created in the 'prepare' sub never gets deleted if it fails there 
already. Cleanup only happens for phases 1, 2 and 3. 

On 4/1/19 7:26 AM, Alexandre DERUMIER wrote: 
>>> oh, and this all lacks a bit of cleanups on errors, e.g., the newly created 
>>> VM on the target side, etc. but it's a bit of a delicate issue, maybe you 
>>> want do have a cleanup command which is executed at the remote side, checks 
>>> if the target vmid is still "migrate" locked and cleans up everything created 
>>> solely for the migration? 
> I'll veriy that again, but I'm pretty sure that vm was correctly deleted in case of errors in 
> differents phases. 
> 
> 
> ----- Mail original ----- 
> De: "Thomas Lamprecht" <t.lamprecht at proxmox.com> 
> À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com> 
> Envoyé: Samedi 30 Mars 2019 17:31:46 
> Objet: Re: [pve-devel] [PATCH v6 qemu-server 2/3] add QemuMigrateExternal.pm 
> 
> On 2/20/19 1:22 AM, Alexandre Derumier wrote: 
>> --- 
>> PVE/Makefile | 1 + 
>> PVE/QemuMigrateExternal.pm | 872 +++++++++++++++++++++++++++++++++++++++++++++ 
>> 2 files changed, 873 insertions(+) 
>> create mode 100644 PVE/QemuMigrateExternal.pm 
>> 
>> diff --git a/PVE/Makefile b/PVE/Makefile 
>> index 2c800f6..0494cfb 100644 
>> --- a/PVE/Makefile 
>> +++ b/PVE/Makefile 
>> @@ -1,6 +1,7 @@ 
>> PERLSOURCE = \ 
>> QemuServer.pm \ 
>> QemuMigrate.pm \ 
>> + QemuMigrateExternal.pm \ 
>> QMPClient.pm \ 
>> QemuConfig.pm 
>> 
> oh, and this all lacks a bit of cleanups on errors, e.g., the newly created 
> VM on the target side, etc. but it's a bit of a delicate issue, maybe you 
> want do have a cleanup command which is executed at the remote side, checks 
> if the target vmid is still "migrate" locked and cleans up everything created 
> solely for the migration? 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 

_______________________________________________ 
pve-devel mailing list 
pve-devel at pve.proxmox.com 
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel