[pve-devel] [RFC ha-manager 00/12] packaging cleanup

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Sep 28 15:38:03 CEST 2018


On 9/28/18 12:48 PM, Fabian Gr├╝nbichler wrote:
> this series cleans up the packaging of our ha-manager repo:
> - general improvements
> - moving of common perl modules into own package instead of shipping them twice in different paths
> - cleanup of dependencies / use statements 
>   (simulator now only requires libpve-common-perl and libpve-ha-common-perl)
> - regular usage of dpkg-buildpackage

much thanks for this!

So for now I applied the low hanging easy fruits, i.e.,
1, 2, 3, 4, 6 and 7.

This should take a bit load of this not too small series.
I'l have a close look at the rest and the meat of this series
next week.

> 
> it does introduce a new binary package, hence the RFC.
> 
> note that some of the intermediate patches are not strictly necessary / could
> be squashed into the bigger ones, but I wanted to keep the whole thing readable
> and reviewable in smaller chunks.
> 
> Fabian Gr├╝nbichler (12):
>   build: remove leftover PHONY declaration
>   remove unused use statements
>   pve-ha-tester: use correct lib path
>   groups: register groups directly
>   Tools: make PVE::Cluster and HA-Env optional
>   sim: don't install real resources
>   sim: don't install PVE::HA::Config
>   build: restructure packaging
>   build: bump compat level to 10
>   debian/control: add missing dependencies
>   build: actually ship SOURCE file
>   bump version to 2.0-6
> 
>  Makefile                                     | 21 +++----------
>  src/Makefile                                 |  9 ++----
>  src/PVE/HA/Makefile                          | 14 +++------
>  src/PVE/HA/Resources/Makefile                |  5 ---
>  src/PVE/HA/Sim/Makefile                      |  6 ++--
>  src/PVE/HA/Sim/Resources/Makefile            |  4 +--
>  src/PVE/Makefile                             |  6 ----
>  changelog.Debian => debian/changelog         | 10 ++++++
>  debian/compat                                |  2 +-
>  debian/control                               | 32 ++++++++++++++++++--
>  debian/libpve-ha-common-perl.docs            |  1 +
>  debian/libpve-ha-common-perl.install         | 10 ++++++
>  debian/pve-ha-manager.docs                   |  1 +
>  debian/pve-ha-manager.install                | 24 +++++++++++++++
>  debian/{triggers => pve-ha-manager.triggers} |  0
>  debian/pve-ha-simulator.docs                 |  1 +
>  debian/pve-ha-simulator.install              |  2 ++
>  simdebian/compat                             |  1 -
>  simdebian/control                            | 14 ---------
>  simdebian/copyright                          | 16 ----------
>  simdebian/rules                              | 20 ------------
>  src/PVE/HA/Config.pm                         |  4 ---
>  src/PVE/HA/FenceConfig.pm                    |  1 -
>  src/PVE/HA/Groups.pm                         |  3 ++
>  src/PVE/HA/Sim/Hardware.pm                   |  4 +--
>  src/PVE/HA/Tools.pm                          | 25 ++++++++++++++-
>  src/pve-ha-simulator                         |  2 +-
>  src/pve-ha-tester                            |  5 +--
>  src/test/ha-tester.pl                        |  3 --
>  src/test/test_failover1.pl                   |  4 +--
>  30 files changed, 130 insertions(+), 120 deletions(-)
>  rename changelog.Debian => debian/changelog (98%)
>  create mode 100644 debian/libpve-ha-common-perl.docs
>  create mode 100644 debian/libpve-ha-common-perl.install
>  create mode 100644 debian/pve-ha-manager.docs
>  create mode 100644 debian/pve-ha-manager.install
>  rename debian/{triggers => pve-ha-manager.triggers} (100%)
>  create mode 100644 debian/pve-ha-simulator.docs
>  create mode 100644 debian/pve-ha-simulator.install
>  delete mode 100644 simdebian/compat
>  delete mode 100644 simdebian/control
>  delete mode 100644 simdebian/copyright
>  delete mode 100755 simdebian/rules
> 





More information about the pve-devel mailing list