[pve-devel] [PATCH pve-spice-protocol 1/4] fix Makefile

Dominik Csapak d.csapak at proxmox.com
Wed Sep 26 15:09:30 CEST 2018


the "all" lead to never satisfying the ${DEB} dependency
since it could not find pacakge_"all".deb

dinstall was defined two times

buildinfo was missing in the clean target

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 Makefile | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index cb657bc..9c43b30 100644
--- a/Makefile
+++ b/Makefile
@@ -7,19 +7,16 @@ PKGRELEASE=1
 PKGDIR=spice-protocol-${PKGVERSION}
 PKGSRC=${PKGDIR}.tar.bz2
 
-ARCH:="all"
+ARCH=all
 
 DEB=${PACKAGE}_${PKGVERSION}-${PKGRELEASE}_${ARCH}.deb
 
 
 all: ${DEB}
 
-.PHONY: dinstall
-dinstall: deb
-	dpkg -i ${DEB}
-
 .PHONY: deb
-${DEB} deb: ${PKGSRC}
+deb: $(DEB)
+$(DEB): ${PKGSRC}
 	rm -rf ${PKGDIR}
 	tar xf ${PKGSRC}
 	cp -a debian ${PKGDIR}/debian
@@ -33,7 +30,7 @@ distclean: clean
 
 .PHONY: clean
 clean:
-	rm -rf *~ debian/*~ *_${ARCH}.deb *.changes *.dsc ${PKGDIR}
+	rm -rf *~ debian/*~ *_${ARCH}.deb *.changes *.buildinfo *.dsc ${PKGDIR}
 
 .PHONY: dinstall
 dinstall: ${DEB}
-- 
2.11.0




More information about the pve-devel mailing list