[pve-devel] [PATCH pve-libspice-server 2/4] replace CELT with libopus

[Thomas Lamprecht]

On 9/25/18 1:36 PM, Dominik Csapak wrote:
> On 9/25/18 1:01 PM, Thomas Lamprecht wrote:
>> On 9/25/18 12:16 PM, Dominik Csapak wrote:
>>> this is now the default upstream and one small library as additional
>>> dependency
>>
>> FYI, Opus is the successor of CELT, whichs development effort stopped
>> and was put into Opus. https://en.wikipedia.org/wiki/CELT
>>
>>> diff --git a/debian/control b/debian/control
>>> index 783f678..d1cbf2d 100644
>>> --- a/debian/control
>>> +++ b/debian/control
>>> @@ -6,6 +6,7 @@ Build-Depends: autotools-dev,
>>>                  libglib2.0-dev,
>>>                  libjpeg-dev,
>>>                  libogg-dev,
>>> +               libopus-dev,
>>>                  libpixman-1-dev (>= 0.17.7~),
>>>                  libsasl2-dev,
>>>                  libssl-dev,
>>
>> And, AFAIS, libspice-server.so gets linked to libopus0, or?
>>
>>
>> # ldd ./server/.libs/libspice-server.so
>>          linux-vdso.so.1 (0x00007ffeda579000)
>>          libgthread-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgthread-2.0.so.0 (0x00007fb45ff9b000)
>>          *libopus.so.0 => /usr/lib/x86_64-linux-gnu/libopus.so.0 (0x00007fb45fd4c000)*
>>          libgio-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0 (0x00007fb45f9b6000)
>>          libgobject-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 (0x00007fb45f763000)
>>          libglib-2.0.so.0 => /lib/x86_64-linux-gnu/libglib-2.0.so.0 (0x00007fb45f44f000)
>>          libjpeg.so.62 => /usr/lib/x86_64-linux-gnu/libjpeg.so.62 (0x00007fb45f1e4000)
>>          liblz4.so.1 => /usr/lib/x86_64-linux-gnu/liblz4.so.1 (0x00007fb45efd2000)
>>          libpixman-1.so.0 => /usr/lib/x86_64-linux-gnu/libpixman-1.so.0 (0x00007fb45ed2b000)
>>          libsasl2.so.2 => /usr/lib/x86_64-linux-gnu/libsasl2.so.2 (0x00007fb45eb10000)
>>          libssl.so.1.1 => /usr/lib/x86_64-linux-gnu/libssl.so.1.1 (0x00007fb45e8a4000)
>>          libcrypto.so.1.1 => /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 (0x00007fb45e411000)
>>          libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fb45e1f7000)
>>          libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fb45def3000)
>>          librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fb45dceb000)
>>          libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fb45dace000)
>>          libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fb45d72f000)
>>          libgmodule-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgmodule-2.0.so.0 (0x00007fb45d52b000)
>>          libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1 (0x00007fb45d303000)
>>          libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fb45d0ec000)
>>          libmount.so.1 => /lib/x86_64-linux-gnu/libmount.so.1 (0x00007fb45ce9e000)
>>          libffi.so.6 => /usr/lib/x86_64-linux-gnu/libffi.so.6 (0x00007fb45cc95000)
>>          libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007fb45ca22000)
>>          /lib64/ld-linux-x86-64.so.2 (0x00007fb4604c7000)
>>          libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fb45c81e000)
>>          libblkid.so.1 => /lib/x86_64-linux-gnu/libblkid.so.1 (0x00007fb45c5d8000)
>>          libuuid.so.1 => /lib/x86_64-linux-gnu/libuuid.so.1 (0x00007fb45c3d3000)
>>
>> Which is no dependency. Note, that on a desktop/development system you'll
>> get this library quickly pulled in, but a system without is possible and
>> tracking dependencies is always good... :) Or do I overlook something here?
>>
> 
> # dpkg -I pve-libspice-server1_0.14.1-1_amd64.deb
>  new debian package, version 2.0.
>  size 621278 bytes: control archive=949 bytes.
>      904 bytes,    20 lines      control
>      394 bytes,     5 lines      md5sums
>       39 bytes,     1 lines      shlibs
>       60 bytes,     2 lines      triggers
>  Package: pve-libspice-server1
>  Source: pve-libspice-server
>  Version: 0.14.1-1
>  Architecture: amd64
>  Maintainer: Proxmox Support Team <support at proxmox.com>
>  Installed-Size: 1475
>  Depends: libc6 (>= 2.14), libglib2.0-0 (>= 2.31.8), libjpeg62-turbo (>= 1.3.1), liblz4-1 (>= 0.0~r130), libopus0 (>= 1.1), libpixman-1-0 (>= 0.30.0), libsasl2-2, libssl1.1 (>= 1.1.0), zlib1g (>= 1:1.1.4)
>  Conflicts: libspice-server1
>  Replaces: libspice-server1
>  Provides: libspice-server1
>  Section: libs
>  Priority: extra
>  Description: SPICE remote display system server library
>   SPICE is a remote display system built for virtual environments which
>   allows you to view a computing 'desktop' environment not only on the
>   machine where it is running, but from anywhere on the Internet and
>   from a wide variety of machine architectures.
>   .
>   This package contains the run-time libraries for any application that
>   wishes to be a SPICE server.
> 
> it lists libopus0 as depency probably because of:
> 
> ----
>  Depends: ${misc:Depends},
>           ${shlibs:Depends},
> ----
> 
> in the control file

not only probably, it's for sure the reason...
Argh, did not checked correctly.