[pve-devel] [RFC 1/2 pve-storage] implement map_volume and unmap_volume

Dietmar Maurer dietmar at proxmox.com
Fri Sep 21 15:21:50 CEST 2018


> I know you just do this to not duplicate the blockdevice path assembly,
> but it feels a bit weird to directly have an map with $nomap method call
> in unmap, maybe pull the common parts out in its own ($private) helper sub?

I though somebody will suggest a better name for that parameter so that it looks more reasonable?



More information about the pve-devel mailing list