[pve-devel] [PATCH manager] ui: form/VMSelector: use SIMPLE mode for guest checkbox model

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Sep 11 09:48:25 CEST 2018


Switch the default mode 'MULTI' with 'SIMPLE', the same we use in the
dc/Backup guest selector. It allows to remove the 'checkOnly'
setting, which limited selection and deselection of elements on the
checkbox it self, doing nothing when clicking on rows.

Besides the friendlier and more streamlined UX this actually fixes a
bug in Firefox (confirmed in version 62, possible in other versions
too) where select/deselect di not worked when clicking in the white
area of the checkbox, but only when clicking on the surrounding
padding.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 www/manager6/form/VMSelector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index c3375fb4..7efad4ce 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -98,7 +98,7 @@ Ext.define('PVE.form.VMSelector', {
 
     selModel: {
 	selType: 'checkboxmodel',
-	checkOnly: true
+	mode: 'SIMPLE'
     },
 
     checkChangeEvents: [
-- 
2.18.0




More information about the pve-devel mailing list