[pve-devel] [PATCH storage v2 0/3] unify generating disknames finding in all plugins

Stoiko Ivanov s.ivanov at proxmox.com
Fri Sep 7 15:08:39 CEST 2018


Changes from v1:
* Incorporated most feedback from Thomas and Wolfgang (Thanks!)
* refactored get_next_vm_diskname into is_valid_vm_diskname and get_next_vm_diskname
* made the number of allowed disks per vm a constant in PVE::Storage::Plugin
  and raised it to 1024 - this is needed for Fabian's raising of the maximal number of
  container mountpoints [1]

Decided to postpone the testing of image generation for another round of patches,
since a few features and fixes are waiting on the current patchset.

[1] https://pve.proxmox.com/pipermail/pve-devel/2018-September/033603.html

Stoiko Ivanov (3):
  add generic get_next_vm_diskname sub
  make max number of disks a constant
  refactor finding next diskname for all plugins

 PVE/Storage/DRBDPlugin.pm      | 15 ++--------
 PVE/Storage/GlusterfsPlugin.pm | 27 ++++++-----------
 PVE/Storage/LVMPlugin.pm       | 22 +++-----------
 PVE/Storage/LvmThinPlugin.pm   |  4 +--
 PVE/Storage/Plugin.pm          | 66 +++++++++++++++++++++++++++++++++---------
 PVE/Storage/RBDPlugin.pm       | 20 ++++---------
 PVE/Storage/SheepdogPlugin.pm  | 21 +++-----------
 PVE/Storage/ZFSPoolPlugin.pm   | 19 ++----------
 8 files changed, 80 insertions(+), 114 deletions(-)

-- 
2.11.0




More information about the pve-devel mailing list