[pve-devel] [PATCH pve-manager] add 'ssbd', 'ibpb', 'virt-ssbd', 'amd-ssbd', 'amd-no-ssb' cpu flags option

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Sep 3 08:41:43 CEST 2018


On 9/2/18 7:54 AM, Alexandre Derumier wrote:
> ---
>  www/manager6/qemu/ProcessorEdit.js | 42 +++++++++++++++++++++++++++++++++-----
>  1 file changed, 37 insertions(+), 5 deletions(-)
> 
> diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
> index 3ecea205..eaec0773 100644
> --- a/www/manager6/qemu/ProcessorEdit.js
> +++ b/www/manager6/qemu/ProcessorEdit.js
> @@ -44,7 +44,7 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
>  
>  	var flags = [];
>  
> -	['pcid', 'spec-ctrl'].forEach(function(flag) {
> +	['pcid', 'spec-ctrl', 'ssbd', 'ibpb', 'virt-ssbd', 'amd-ssbd', 'amd-no-ssb'].forEach(function(flag) {
>  	    if (values[flag]) {
>  		flags.push('+' + flag.toString());
>  	    }
> @@ -150,7 +150,26 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
>  	    value: '1024',
>  	    deleteEmpty: true,
>  	    allowBlank: true
> +	},
> +	{
> +	    xtype: 'proxmoxcheckbox',
> +	    fieldLabel: 'PCID',
> +	    name: 'pcid',
> +	    uncheckedValue: 0
> +	},
> +	{
> +	    xtype: 'proxmoxcheckbox',
> +	    fieldLabel: 'SPEC-CTRL',
> +	    name: 'spec-ctrl',
> +	    uncheckedValue: 0
> +	},
> +	{
> +	    xtype: 'proxmoxcheckbox',
> +	    fieldLabel: 'SSBD',
> +	    name: 'ssbd',
> +	    uncheckedValue: 0
>  	}
> +
>      ],
>  
>      advancedColumn2: [
> @@ -162,16 +181,29 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
>  	},
>  	{
>  	    xtype: 'proxmoxcheckbox',
> -	    fieldLabel: 'PCID',
> -	    name: 'pcid',
> +	    fieldLabel: 'IBPB',
> +	    name: 'ibpb',
>  	    uncheckedValue: 0
>  	},
>  	{
>  	    xtype: 'proxmoxcheckbox',
> -	    fieldLabel: 'SPEC-CTRL',
> -	    name: 'spec-ctrl',
> +	    fieldLabel: 'VIRT-SSBD',
> +	    name: 'virt-ssbd',
> +	    uncheckedValue: 0
> +	},
> +	{
> +	    xtype: 'proxmoxcheckbox',
> +	    fieldLabel: 'AMD-SSBD',
> +	    name: 'amd-ssbd',
> +	    uncheckedValue: 0
> +	},
> +	{
> +	    xtype: 'proxmoxcheckbox',
> +	    fieldLabel: 'AMD-NO-SSB',
> +	    name: 'amd-no-ssb',
>  	    uncheckedValue: 0
>  	}
> +
>      ]
>  });
>  

I think we need another way to show this...
Having it like this is very confusing, IMO, and there will probably come more.

Maybe a grid with checkboxes, a flag name column and a description column
where we can put at least a minimal description about what this is?

A combobox (with same grid and multiselect) could be done too, would need less
space, so maybe even better.



More information about the pve-devel mailing list