[pve-devel] [PATCH qemu-server 02/13] add 'arch' vm configuration

[Thomas Lamprecht]

Am 10/25/2018 um 04:19 PM schrieb Dominik Csapak:
> On 10/24/18 10:56 AM, Wolfgang Bumiller wrote:
>> @@ -3175,7 +3215,7 @@ sub config_to_command {
>>         my $q35 = machine_type_is_q35($conf);
>>       my $hotplug_features = parse_hotplug_features(defined($conf->{hotplug}) ? $conf->{hotplug} : '1');
>> -    my $machine_type = $forcemachine || $conf->{machine};
>> +    my $machine_type = $forcemachine || $base_machine;
> 
> this seems wrong, since we lose all version info about the machine
> (e.g. if someone uses pc-2.5)

the get_basic_machine_info sub uses $conf->{machine} so your implication is wrong?
This look OK, AFAICT.

> 
>>       my $use_old_bios_files = undef;
>>       ($use_old_bios_files, $machine_type) = qemu_use_old_bios_files($machine_type);
>>