[pve-devel] [PATCH manager 5/5] build: use pve-doc-generator to verify API

[Thomas Lamprecht]

On 10/22/18 8:00 PM, Fabian Grünbichler wrote:
> On Thu, Oct 18, 2018 at 02:27:05PM +0200, Thomas Lamprecht wrote:
>> On 10/17/18 1:02 PM, Fabian Grünbichler wrote:
>>> and move API verification to 'check' target, where it belongs.
>>>
>>> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
>>> ---
>>>  Makefile     | 4 +++-
>>>  bin/Makefile | 9 +++++----
>>>  2 files changed, 8 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 8d462915..8eb5928f 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -17,7 +17,9 @@ DEB=${PACKAGE}_${VERSION}-${PACKAGERELEASE}_${ARCH}.deb
>>>  all: ${SUBDIRS}
>>>  	set -e && for i in ${SUBDIRS}; do ${MAKE} -C $$i; done
>>>  
>>> -check:
>>> +.PHONY: check
>>> +check: bin tests
>>                  ^^^
>> there's no tests directory (yet ;-)) and thus fails the target, and thus the build:
>>
>> s/tests/test/
> 
> indeed there is not :) this is a leftover of a rebase dropping some
> additional stuff that did not make the cut for this series - should I
> resend or do you want to fix this up when applying?

Fixing up is OK for me.