[pve-devel] [PATCH manager 2/2] Completing Build-Depends

[Fabian Grünbichler]

On Thu, Oct 11, 2018 at 12:05:20PM +0200, Rhonda D'Vine wrote:
> These were the missing Build-Depends that were needed in building this
> package.
> 
> Signed-off-by: Rhonda D'Vine <rhonda at proxmox.com>
> ---

patch LGTM, the following is only semi-related ;)

I assume you tested this by generating a source package and then
building that in a clean chroot? because when I attempt that, I get the
following error:

make[2]: Entering directory '/build/pve-manager-5.2/bin'
cp /usr/share/pve-doc-generator/vzdump.adoc vzdump.adoc.tmp
mv vzdump.adoc.tmp vzdump.adoc
PVE_GENERATING_DOCS=1 perl -I. -e "use PVE::CLI::vzdump;print PVE::CLI::vzdump->generate_asciidoc_synopsis();" > vzdump.1-synopsis.adoc.tmp
/usr/share/pve-doc-generator/pve-doc-generator.mk:33: recipe for target 'vzdump.1-synopsis.adoc' failed
make[2]: Leaving directory '/build/pve-manager-5.2/bin'
Makefile:42: recipe for target 'install' failed

which looks to me like we probably should extend pve-doc-generator.mk to
allow adding additional include paths on the caller side ('..' in this
case)?

how did you avoid that issue? our general build environment has all the
basic PVE packages installed, which likely masked this issue until now..

>  debian/control | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/debian/control b/debian/control
> index e0860c33..7e2a91e5 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -1,11 +1,20 @@
>  Source: pve-manager
>  Section: admin
>  Priority: optional
> -Build-Depends: libfile-readbackwards-perl,
> +Build-Depends: debhelper (>= 9~),
> +               libfile-readbackwards-perl,
> +               libhttp-daemon-perl,
>                 liblocale-po-perl,
> +               libpve-guest-common-perl,
>                 libpve-http-server-perl,
> +               libpve-storage-perl,
>                 libtemplate-perl,
> +               libtest-mockmodule-perl,
> +               pve-cluster,
> +               pve-container,
>                 pve-doc-generator (>= 5.2-6),
> +               qemu-server,
> +               unzip,
>  Maintainer: Proxmox Support Team <support at proxmox.com>
>  
>  Package: pve-manager
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel