[pve-devel] applied: [PATCH v4 pve-manager] API2 : Network : add network config reload

[Alexandre DERUMIER]

>>applied, and added a few cleanups on top. 

Thanks Dietmar !


>>Please can you try to solve those issues marked as 'clean me'? 

I'm not sure what is the best/cleanest way to read/write and parse /etc/network/interfaces ?



----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "pve-devel" <pve-devel at pve.proxmox.com>, "aderumier" <aderumier at odiso.com>
Envoyé: Lundi 8 Octobre 2018 13:36:21
Objet: applied: [pve-devel] [PATCH v4 pve-manager] API2 : Network : add network config reload

applied, and added a few cleanups on top. 

Please can you try to solve those issues marked as 'clean me'? 

> On October 2, 2018 at 9:19 AM Alexandre Derumier <aderumier at odiso.com> wrote: 
> 
> 
> This add a new api to online reload networking configuration 
> with ifupdown2. 
> 
> This work with native ifupdown2 modules, as ifupdown2 have 
> interface dependency relationships. 
> 
> Some specific interfaces options can't be reloaded online 
> (because kernel don't implement it), it this case, we ifdown/ifup 
> theses interfaces. (mainly vxlan interfaces options) 
> --- 
> changelog v4: 
> - parse running and new config to detect bridge removal && ovs change 
> instead using diff 
> - clean whitespaces errors 
> 
> changelog v3: 
> - catch errors on reloading, and try to ifdown/ifup interfaces 
> - if an interfaces really can't be reloaded, of ifdown/ifup, 
> revert current config of theses interfaces and keep interfaces.new file 
> 
> changelog v2: 
> 
> - remove restart option 
> - check if vm|ct are running on a bridge delete 
> - run the networking service reload in a task