[pve-devel] applied: [PATCH storage v2 0/3] refactor checks/fix #1929
Thomas Lamprecht
t.lamprecht at proxmox.com
Wed Oct 3 15:11:00 CEST 2018
On 9/25/18 10:37 AM, Dominik Csapak wrote:
> changes from v1:
>
> incorporated improvements from thomas suggestions
>
> i am not really sure if we want to refactor the one line check of
> 'die not unusuded if is_used'
>
> did not do the rename of 'verify_blockdev_path' yet, can be done in a
> future patchset
>
> Dominik Csapak (3):
> refactor disk/storage checks for Disk API
> add missing storage check in LVM Disk API
> fix #1929: only check storage if user want to create one
>
> PVE/API2/Disks/Directory.pm | 9 ++-------
> PVE/API2/Disks/LVM.pm | 3 ++-
> PVE/API2/Disks/LVMThin.pm | 9 ++-------
> PVE/API2/Disks/ZFS.pm | 8 ++------
> PVE/Diskmanage.pm | 8 ++++++++
> PVE/Storage.pm | 12 ++++++++++++
> 6 files changed, 28 insertions(+), 21 deletions(-)
>
applied, with my suggested method rename fixup on top.
thanks!
More information about the pve-devel
mailing list