[pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

Fabian Grünbichler f.gruenbichler at proxmox.com
Mon Oct 1 19:43:41 CEST 2018


On Mon, Oct 01, 2018 at 12:41:57PM +0200, Stoiko Ivanov wrote:
> I would propose to disable the default creation of a swap-zvol if installing
> with zfs on root currently, since it introduces deadlocks in some circumstances.
> 
> Should a solution be implemented, we can revert the changes.
> 
> This patchset contains 4 changes:
> * disabling the creation of a zvol for swap by default.
> * adding a GTKEntry field to the ZFS advanced options for users, who still
>   want a zvol with swap

wouldn't it make more sense to create a swap partition on all boot vdevs
instead? if you need swap, this is very cumbersome to do after
installation. creating a swap zvol is easily possible no matter whether
the installer supports it or not..

> * checking/creating ZFS swap when running in test mode as well
> * tiny change to the test image creation (using truncate instead of dd,
>   which makes the initial rsync while testing faster)
> 
> The last patch is independent of the others (but doesn't justify a thread of its
> own IMO).
> 
> Stoiko Ivanov (4):
>   no swap on zfs unless it's explicitly set
>   add entry for swapsize to ZFS advanced widget
>   add swapcreation to zfs testmode
>   buildsys: use truncate to create test.img
> 
>  Makefile    |  2 +-
>  proxinstall | 22 ++++++++++++++++++++--
>  2 files changed, 21 insertions(+), 3 deletions(-)
> 
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list