[pve-devel] [RFC/PATCH installer 0/4] don't create swap on ZFS as default

[Thomas Lamprecht]

On 10/1/18 12:41 PM, Stoiko Ivanov wrote:
> I would propose to disable the default creation of a swap-zvol if installing
> with zfs on root currently, since it introduces deadlocks in some circumstances.
> 
> Should a solution be implemented, we can revert the changes.
> 
> This patchset contains 4 changes:
> * disabling the creation of a zvol for swap by default.
> * adding a GTKEntry field to the ZFS advanced options for users, who still
>   want a zvol with swap
> * checking/creating ZFS swap when running in test mode as well
> * tiny change to the test image creation (using truncate instead of dd,
>   which makes the initial rsync while testing faster)
> 
> The last patch is independent of the others (but doesn't justify a thread of its
> own IMO).
> 
> Stoiko Ivanov (4):
>   no swap on zfs unless it's explicitly set
>   add entry for swapsize to ZFS advanced widget
>   add swapcreation to zfs testmode
>   buildsys: use truncate to create test.img
> 
>  Makefile    |  2 +-
>  proxinstall | 22 ++++++++++++++++++++--
>  2 files changed, 21 insertions(+), 3 deletions(-)
> 

Looks good to me, I'll let it still ripe a bit on the mailing list though,
for other possible commenters :-)