[pve-devel] [PATCH qemu-server] Fix #1242 : clone_disk : call qga fstrim after clone

[Thomas Lamprecht]

On 5/28/18 5:36 PM, Alexandre Derumier wrote:
> Some storage like rbd or lvm can't keep thin-provising after a qemu-mirror.
> 
> Call qga guest-fstrim if qga is available

Shouldn't the VM internal fstrim cronjob/timer (or windows equivalent)
do this anyway sooner or later?

I mean, although I understand your use case, this can really be a big and
long operation, not sure if we want to do this unconditionally for qga
enabled VMs.

If we actually do this I rather would go the way proposed in this thread
and convert qga to an format_string, then we could convert the QGA UI
dialog to a small component with checkbox(es):

qga: 1,fstrim_cloned_disks=1

(it could be argued what the default should be)

Maybe we get, or even have already, some more operations regarding the
QGA where it makes sense to have a similar approach.

cheers,
Thomas