[pve-devel] [PATCH http-server 2/2] Fix #1684 WebSocket proxy behind a buffered proxy.

Dietmar Maurer dietmar at proxmox.com
Sat May 26 08:35:52 CEST 2018


> On May 25, 2018 at 5:20 PM Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:
> 
> 
> On 5/25/18 3:20 PM, René Jochum wrote:
> > The given patch fixes incoming WebSocket traffic behind buffered Proxies
> > like Nginx.
> > 
> > This fixes the "blank screen" problem users reported on the forums.
> > 
> > To have a fully working Nginx Reverse Proxy setup its important to
> > update nginx to 1.14 from the upstream repo.
> 
> With git show -w this patch looks actually not that big anymore..
> IMO it's good practice to mention if most of the changes are just
> indentation ones, reviewers get less scared then and the patch will
> find it's way faster into git :)

Yes! I can understand the patch now ;-)



More information about the pve-devel mailing list