[pve-devel] applied: [PATCH manager] fix notes gear tool

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 25 17:32:21 CEST 2018


On 5/25/18 5:27 PM, Dominik Csapak wrote:
> me was used before it was defined
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> this is the first actual bug i found with jslint o.O
> btw, seems someone does not use jslint before committing ;)
>  www/manager6/panel/NotesView.js | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/www/manager6/panel/NotesView.js b/www/manager6/panel/NotesView.js
> index 94408837..23f4b6e9 100644
> --- a/www/manager6/panel/NotesView.js
> +++ b/www/manager6/panel/NotesView.js
> @@ -57,6 +57,7 @@ Ext.define('PVE.panel.NotesView', {
>      tools: [{
>  	type: 'gear',
>  	handler: function() {
> +	    var me = this.up('panel');
>  	    me.run_editor();
>  	}
>      }],
> 

I even tested CT/VM nodes, to see if they still work,
but only through double click... :/

applied, thanks



More information about the pve-devel mailing list