[pve-devel] [PATCH manager stable-4] add eol notice

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 25 16:31:58 CEST 2018


On 5/25/18 1:57 PM, Dominik Csapak wrote:
> since pve 4.4 goes out of support in june, add a notice at the top with
> a link to the faq, where the EOL dates are
> 

how about the following light adaptions?:

I use warning and fa-lg for the icon, omit the repoid from the
version as we do in PVE 5 already, to save space.

I omit the 'Click for Details' it's unecessary for two reasons:
* if this pops up people take a look and recognize that this is a link
* you really do not get more details from the linked article, you just
see the EOL date again, we probably should add either a FAQ point for
upgrades linking to the etablished wiki articles (adding a new one once
every 2 years seems to be maintainable) or add a specific section to
pve-docs which describes an major upgrade in general (plus linking to
the respective articles). We then could link such EOL messages to those,
as there an admin actually gets some details/information...
(I understand that this cannot achieved by your patch directly and you
used the best fitting link, just noting)

centered it and removed the fixed width (two lines look strange here).
Added a tooltip, if you think there's information missing in the link
text I would put it there.

A thing I'm not really happy with is that this is always seen, even
if logged out. It would be nicer to only get the information after an
successful ticket was created, leaking version information that plain
in sight is not really ideal :/ (even if you always can determine the
rough PVE version used by comparing pvemanagerlib.js with builts from
git  until you find a match - but that's at least work :) )

----8<----
diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css
index f42e935e..0114604f 100644
--- a/www/css/ext6-pve.css
+++ b/www/css/ext6-pve.css
@@ -517,3 +517,10 @@ table.osds td:first-of-type {
 .x-webkit :not(.x-form-textarea-body) > .x-form-trigger-wrap {
     height: initial;
 }
+
+.eolicon {
+    position: relative;
+    top: 4px;
+    float: left;
+    margin-right: 5px;
+}
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index d5e7d718..16a1aec8 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -185,9 +185,8 @@ Ext.define('PVE.StdWorkspace', {
        var ui = me.query('#versioninfo')[0];

        if (PVE.VersionInfo) {
-           var version = PVE.VersionInfo.version + '-' + PVE.VersionInfo.release + '/' +
-               PVE.VersionInfo.repoid;
-           ui.update('Virtual Environment ' + version);
+           var version = PVE.VersionInfo.version + '-' + PVE.VersionInfo.release;
+           ui.update('Virtual Environment ' + version );
        } else {
            ui.update('Virtual Environment');
        }
@@ -303,7 +302,6 @@ Ext.define('PVE.StdWorkspace', {
                                '<img style="padding-top:4px;padding-right:5px" src="/pve2/images/proxmox_logo.png"/></a>'
                        },
                        {
-                           minWidth: 200,
                            id: 'versioninfo',
                            html: 'Virtual Environment'
                        },
@@ -311,6 +309,19 @@ Ext.define('PVE.StdWorkspace', {
                            xtype: 'pveGlobalSearchField',
                            tree: rtree
                        },
+                       { flex: 1 },
+                       {
+                           id: 'eolannouncement',
+                           padding: '5 0',
+                           //width: 220,
+                           html: '<a href="https://pve.proxmox.com/wiki/FAQ" target="_blank">'+
+                                   '<i class="fa fa-lg eolicon warning fa-exclamation-triangle"></i>' +
+                                   'Support for 4.4 ends on 30.06.2018</a>',
+                           autoEl: {
+                               tag: 'div',
+                               'data-qtip': gettext("You won't get any security fixes after the EOL date. Please consider upgrading.")
+                           }
+                       },
                        {
                            flex: 1
                        },



More information about the pve-devel mailing list