[pve-devel] applied: [PATCH manager v2 0/3] add notes panel to nodes

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 25 11:16:36 CEST 2018


On 5/25/18 10:31 AM, Dominik Csapak wrote:
> as for the commment from thomas:
> 
> i wanted to put it in the 'summary' tab, but there is no way to put it there
> without changing the amount of info/graphs you see by default
> and since we do not want to disrupt users view of data, i put it
> as its own tab
> 
> in the future, we possibly have more node specific configuration we
> can put there, so we need a new tab anyway
> 

not sure if this is the right place but it's the best we came up
for now, so applied series

> changes from v1:
> * refactor the NotesView more and add an 'edit' button for the node
>   instead of showing the header to make it more consistent with the
>   rest of our gui
> 
> Dominik Csapak (3):
>   let NotesView load itself
>   accept type 'node' for NotesView and refactor it
>   fix #427: add notes panel to node
> 
>  www/manager6/lxc/Summary.js     |  1 -
>  www/manager6/node/Config.js     |  6 +++
>  www/manager6/panel/NotesView.js | 89 +++++++++++++++++++++++++----------------
>  www/manager6/qemu/Summary.js    |  1 -
>  4 files changed, 60 insertions(+), 37 deletions(-)
> 




More information about the pve-devel mailing list