[pve-devel] [PATCH manager 1/3] check for VM.Montior privileges on qemu AgentIPView
Dominik Csapak
d.csapak at proxmox.com
Tue May 22 14:02:33 CEST 2018
so that the user does not get the useless 'no information' or
'not running' message, but the real cause
Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
www/manager6/qemu/AgentIPView.js | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index ecc091f1..13fe3e9a 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -128,15 +128,22 @@ Ext.define('PVE.qemu.AgentIPView', {
me.running = (store.getById('status').data.value === 'running');
/*jslint confusion: false*/
+ var caps = Ext.state.Manager.get('GuiCap');
+
+ if (!caps.vms['VM.Monitor']) {
+ me.updateStatus(false, gettext('Need VM.Monitor privileges'));
+ return;
+ }
+
if (me.agent && me.running && me.ipStore.isStopped) {
me.ipStore.startUpdate();
}
me.updateStatus();
},
- updateStatus: function(unsuccessful) {
+ updateStatus: function(unsuccessful, defaulttext) {
var me = this;
- var text = gettext('No network information');
+ var text = defaulttext || gettext('No network information');
var more = false;
if (unsuccessful) {
text = gettext('Guest Agent not running');
--
2.11.0
More information about the pve-devel
mailing list