[pve-devel] [PATCH qemu-server 2/3] fix logic of deleting balloon

Dominik Csapak d.csapak at proxmox.com
Tue May 22 13:31:35 CEST 2018


On 05/22/2018 01:24 PM, Wolfgang Bumiller wrote:
> On Mon, May 14, 2018 at 02:03:04PM +0200, Dominik Csapak wrote:
>> deleting balloon means to skip ballooning or to add a balloning device
>> skipping ballooning is ok (with a reset to memory),
>> but it is not possible to hotplug a ballooning device
>> so we have to reverse the logic here, and possibly reset the ballooning value
> 
> Can I reword this like this?
> 
>      Deleting the balloon config entry means resetting it to its
>      default. This means having a balloon device but not actually
>      doing any ballooning with it (iow. resetting the VM's
>      'balloon' value to its specified memory.).
>      Hotplugging a balloon device (coming from explicit '0' to
>      any other value (including deleting it)) is not possible.
> 
> 

sure, this is much better ;)



More information about the pve-devel mailing list