[pve-devel] [PATCH qemu-server] Improve error message of shared storage connection check.

Wolfgang Link w.link at proxmox.com
Fri May 18 10:26:19 CEST 2018


Now you see if the storage plugin support it, extra information about the error.
---
 PVE/QemuMigrate.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 27cf7e3..55a5554 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -242,8 +242,9 @@ sub prepare {
 	if ($scfg->{shared}) {
 	    # PVE::Storage::activate_storage checks this for non-shared storages
 	    my $plugin = PVE::Storage::Plugin->lookup($scfg->{type});
-	    warn "Used shared storage '$sid' is not online on source node!\n"
-		if !$plugin->check_connection($sid, $scfg);
+	    my $res = eval { $plugin->check_connection($storage, $scfg) };
+	    warn "Used shared storage '$sid' is not online on source node! - $res\n"
+		if $res ne 1;
 	} else {
 	    # only activate if not shared
 	    push @$need_activate, $volid;
-- 
2.11.0




More information about the pve-devel mailing list