[pve-devel] [PATCH manager] ui: dc/storage: allow to renenable iscsi storages again

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 18 08:59:13 CEST 2018


The dc/storage refactoring done in
commit 8f60ee4ccacc14f1bbe025874522c151cc375f83
introduced a regression where an once deactivated iSCSI storage could
not be activated again through UI, as we did not called the parent
setValue function correctly, thus the Enable checkbox was always set
to true. A uncheck -> check cycle couldn't also be done as the dirty
changes check disabled the submit button in this case.

Enable/Disable through API or CLI still worked.

Reported-by: Bastian Sebode <b.sebode at linet-services.de>
Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 www/manager6/storage/IScsiEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js
index 33a198dd..6a7db2af 100644
--- a/www/manager6/storage/IScsiEdit.js
+++ b/www/manager6/storage/IScsiEdit.js
@@ -70,7 +70,7 @@ Ext.define('PVE.storage.IScsiInputPanel', {
 
     setValues: function(values) {
 	values.luns = (values.content === 'images') ? true : false;
-	this.callParent();
+	this.callParent([values]);
     },
 
     initComponent : function() {
-- 
2.14.2




More information about the pve-devel mailing list