[pve-devel] applied/comment: [PatchV2 storage] Handel connection check timeouts.

Fabian Gr├╝nbichler f.gruenbichler at proxmox.com
Wed May 16 10:08:59 CEST 2018


with fixed-up commit message. but IMHO it would make sense to follow up
with some variant of:
- warn instead of die if the $out_str contains an error status code
- check for more error status codes
- maybe 'warn "$err\n";' as well?

On Wed, May 16, 2018 at 09:08:06AM +0200, Wolfgang Link wrote:
> ---
>  PVE/Storage/CIFSPlugin.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
> index 1670a5c..724fb1f 100644
> --- a/PVE/Storage/CIFSPlugin.pm
> +++ b/PVE/Storage/CIFSPlugin.pm
> @@ -218,7 +218,8 @@ sub check_connection {
>      };
>  
>      if (my $err = $@) {
> -	die "$out_str\n" if ($out_str =~ m/NT_STATUS_ACCESS_DENIED/);
> +	die "$out_str\n" if defined($out_str) &&
> +	    ($out_str =~ m/NT_STATUS_ACCESS_DENIED/);
>  	return 0;
>      }
>  
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



More information about the pve-devel mailing list