[pve-devel] [PATCH 1/1] Add pci.3 to pve-q35.cfg required by iothread

[Thomas Lamprecht]

On 4/30/18 1:40 PM, Wolfgang Bumiller wrote:
> On Mon, Apr 30, 2018 at 08:06:56AM +0200, Thomas Lamprecht wrote:
>> On 4/29/18 6:17 PM, Kamil Trzciński wrote:
>>> ---
>>>  pve-q35.cfg | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/pve-q35.cfg b/pve-q35.cfg
>>> index 05f85f0..c233036 100644
>>> --- a/pve-q35.cfg
>>> +++ b/pve-q35.cfg
>>> @@ -145,3 +145,9 @@
>>>    bus = "pcidmi"
>>>    addr = "3.0"
>>>    chassis_nr = "3"
>>> +
>>> +[device "pci.3"]
>>> +  driver = "pci-bridge"
>>> +  bus = "pcidmi"
>>> +  addr = "4.0"
>>> +  chassis_nr = "4"
>>>
>>
>>
>> Breaks new to old migration, but we were always pretty OK
>> with that, as else we could not do pretty much anything.
>>
>> Old to new still works, so if no objection arises I'd pull
>> this later today.
> 
> If you do, fix the commit message, please, as it is wrong:
> The case where we do miss the pci.3 bridge is when using
> virtio-scsi-single, regardless of whether io threads are enabled,
> because we always put those controllers on pci bus 3 (see
> QemuServer/PCI.pm)
> 
> But maybe check config_to_command:3544's case (near the comment:
> 	# add pci bridges
> 
> Perhaps instead of disabling this altogether for q35 we should just
> filter out the ones we already have in pve-q35.cfg?
> 

would be the cleaner longterm solution, but I'll apply Kamil's
workaround with an improved commit message for now.